Skip to content

CLOUDP-251999: [skunkworks] add "atlas" CRD category and short names #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

s-urbaniak
Copy link
Collaborator

@s-urbaniak s-urbaniak commented May 13, 2024

This adds a kubectl get atlas to be able to retrieve all atlas resources:

$ kubectl get atlas -A
NAMESPACE   NAME                                            AGE
ns-search   atlasdeployment.atlas.mongodb.com/search-test   9s

NAMESPACE   NAME                                        NAME
ns-search   atlasproject.atlas.mongodb.com/my-project   atlas-search-test

NAMESPACE   NAME                                                                       AGE
ns-search   atlassearchindexconfig.atlas.mongodb.com/test-search-index-config          8s
ns-search   atlassearchindexconfig.atlas.mongodb.com/test-search-index-config-simple   8s

Additionally, this introduces short names for our CRDs:

NAME                              SHORTNAMES
atlasbackuppolicies               abp
atlasbackupschedules              abs
atlasdatabaseusers                adu
atlasdatafederations              adf
atlasdeployments                  ad
atlasfederatedauths               afa
atlasprojects                     ap
atlassearchindexconfigs           asic
atlasstreamconnections            asc
atlasstreaminstances              asi
atlasteams                        at

This can be used as a shortcut to i.e. list all Atlas Deployments like so:

$ kubectl get ad -A
NAMESPACE   NAME          AGE
ns-search   search-test   52s

Copy link
Contributor

github-actions bot commented May 13, 2024

@s-urbaniak
Copy link
Collaborator Author

spoke with @dan-mckean: we want to write a small PD and scope for this. Once ratified, we can merge this. Putting on hold until then.

@s-urbaniak s-urbaniak added the hold Do not merge for now label May 14, 2024
@s-urbaniak s-urbaniak marked this pull request as draft May 14, 2024 13:41
@s-urbaniak s-urbaniak changed the title [skunkworks] add "atlas" CRD category and short names CLOUDP-251999: [skunkworks] add "atlas" CRD category and short names Jun 6, 2024
@s-urbaniak
Copy link
Collaborator Author

as clarified with @dan-mckean we're solving this as a regular Story without PD, scope, spec.

@s-urbaniak
Copy link
Collaborator Author

this needs a rebase and adding printcolumns

@s-urbaniak s-urbaniak removed the hold Do not merge for now label Jun 27, 2024
@s-urbaniak s-urbaniak marked this pull request as ready for review June 27, 2024 09:16
@s-urbaniak
Copy link
Collaborator Author

all done and ready for a final pass.

Copy link
Collaborator

@roothorp roothorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, this feels like a huge usability improvement for a few LoC. Do we need docs for this, or is a release note sufficient?

@s-urbaniak
Copy link
Collaborator Author

@roothorp this definitely needs good docs

@s-urbaniak s-urbaniak merged commit 4d0fca2 into main Jun 27, 2024
58 of 71 checks passed
@s-urbaniak s-urbaniak deleted the categories branch June 27, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants