Skip to content

CLOUDP-285107: fix data federation endpoint reconciliation #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 18, 2024
Merged

CLOUDP-285107: fix data federation endpoint reconciliation #1929

merged 6 commits into from
Nov 18, 2024

Conversation

s-urbaniak
Copy link
Collaborator

This is an alternative to #1928 and introduces a state machine handling.

It also prevents accidental deletion of data federation private endpoints that are not tracked by AKO.

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@s-urbaniak s-urbaniak mentioned this pull request Nov 14, 2024
Closed
3 tasks
@s-urbaniak s-urbaniak force-pushed the CLOUDP-283049-state-machine branch from 6b10e0b to da6fe5a Compare November 14, 2024 12:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/46a504c6fa326037607bcc51e1518c3ede092330

josvazg
josvazg approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some non blocking questions and suggestions

@s-urbaniak s-urbaniak merged commit 19f1517 into main Nov 18, 2024
56 checks passed
@s-urbaniak s-urbaniak deleted the CLOUDP-283049-state-machine branch November 18, 2024 08:46
@s-urbaniak s-urbaniak changed the title CLOUDP-283049: fix data federation endpoint reconciliation CLOUDP-285107: fix data federation endpoint reconciliation Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-urbaniak @josvazg @igor-karpukhin @helderjs