CLOUDP-299197: AtlasNetworkContainer CRD Controller #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
changed the title
josvazg
force-pushed
the
CLOUDP-299197/network-container-crd
branch
3 times, most recently
from
26f25bd to
5833a28
Compare
josvazg
changed the title
josvazg
requested review from
helderjs,
s-urbaniak,
igor-karpukhin and
roothorp
josvazg
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new Network Container CRD and controller support, partly deprecating the Network Peering Connection sub-resources within the Atlas Project CRD and under the project controller. As a follow up, Another PR will include the Network Peering Connection CRD and controller support that effectively makes the old sub-resources deprecated on next release.
Also related #2086 prepares the deprecated sub-resources to not fight against the new independent CRDs.
The PR consists on two steps completing the functionality, to be included as individual commits:
All Submissions: