CLOUDP-299865: Correctly Cleanup Connection Secrets #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roothorp
force-pushed
the
cloudp-299865-deleting-conn-secrets
branch
from
ea123d1 to
fef6e05
Compare
roothorp
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
s-urbaniak
approved these changes
Feb 20, 2025
helderjs
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently discover 'orphaned' connection secrets by listing deployments. We don't list Flex deployments correctly, so connection secrets associated with Flex clusters will be 'cleaned up' (deleted). This only happens on subsequent reconciles (updates), not on creation.
This PR makes sure we correctly list Flex clusters, and tests that connection secrets are appropriately cleaned up.
Fixes #2138
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).