Skip to content

CLOUDP-303120: fix: Don't panic on deep copy of backup compliance. #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

segui-mdb
Copy link
Contributor

The pointers can be nil in which case it will panic. Use the getter to ensure it's always initialized.

All Submissions:

  • [X ] Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

The pointers can be nil in which case it will panic. Use the getter to
ensure it's always initialized.
@s-urbaniak s-urbaniak added the cloud-tests Run expensive Cloud Tests: Integration & E2E label Feb 26, 2025
@s-urbaniak s-urbaniak changed the title fix: Don't panic on deep copy of backup compliance. CLOUDP-303120: fix: Don't panic on deep copy of backup compliance. Feb 26, 2025
Copy link
Collaborator

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, thank you! 🎉 just a small remark to have a better test coverage, else LGTM.

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-urbaniak s-urbaniak merged commit 039da8d into mongodb:main Mar 4, 2025
11 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-tests Run expensive Cloud Tests: Integration & E2E safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants