Skip to content

CLOUDP-313040: Fix DryRun #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

CLOUDP-313040: Fix DryRun #2268

merged 1 commit into from
Apr 23, 2025

Conversation

helderjs
Copy link
Collaborator

Summary

In DRY RUN mode, AKOv2 does not emit Kubernetes events for operations that manage team associations with AtlasProject resources. This is caused by a bug where the underlying error is silently swallowed, preventing proper event reporting. As a result, users receive no indication that an action would have taken place. The expected behavior is that AKOv2 should surface these operations as Kubernetes events when in DRY RUN mode, to maintain full visibility of intended changes.

Proof of Work

Unit tests were added

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@helderjs helderjs requested a review from a team as a code owner April 15, 2025 13:33
@josvazg josvazg merged commit 8093227 into main Apr 23, 2025
134 of 135 checks passed
@josvazg josvazg deleted the CLOUDP-313040-fix-dryrun branch April 23, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants