Updates Service if adding Prometheus. #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigovalin
requested review from
chatton,
irajdeep,
ciprian-tibulca,
priyolahiri and
mircea-cosbuc
as code owners
rodrigovalin
commented
Mar 8, 2022
| @@ -5,12 +5,6 @@ kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.4.1 | |||
| service.binding/type: 'mongodb' | |||
There was a problem hiding this comment.
I will remove this deletions.
rodrigovalin
force-pushed
the
fix-prometheus-service-update
branch
from
36617d0 to
50d10ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
A service will be updated on each reconciliation. Needed if Prometheus is added to a MongoDB resource with no Prometheus beforehand.
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).