ci(NODE-5615): unit test on Node18 and Node20 (#3879)

Author: baileympearson

.evergreen/ci_matrix_constants.js

@@ -1,8 +1,8 @@
 const MONGODB_VERSIONS = ['latest', 'rapid', '7.0', '6.0', '5.0', '4.4', '4.2', '4.0', '3.6'];
 const versions = [
-  { codeName: 'gallium', versionNumber: 16 },
-  { codeName: 'hydrogen', versionNumber: 18 },
-  { codeName: 'iron', versionNumber: 20 }
+  { codeName: 'gallium', versionNumber: 16, npmVersion: 9 },
+  { codeName: 'hydrogen', versionNumber: 18, npmVersion: 'latest' },
+  { codeName: 'iron', versionNumber: 20, npmVersion: 'latest' }
 ];
 const NODE_VERSIONS = versions.map(({ versionNumber }) => versionNumber).sort();
 const LOWEST_LTS = NODE_VERSIONS[0];

.evergreen/config.yml

@@ -2969,9 +2969,9 @@ tasks:
       - func: add aws auth variables to file
       - func: setup aws env
       - func: run aws auth test AssumeRoleWithWebIdentity with AWS_ROLE_SESSION_NAME set
-  - name: run-unit-tests
+  - name: run-unit-tests-node-16
     tags:
-      - run-unit-tests
+      - unit-tests
     commands:
       - command: expansions.update
         type: setup
@@ -2981,9 +2981,33 @@ tasks:
             - {key: NPM_VERSION, value: '9'}
       - func: install dependencies
       - func: run unit tests
+  - name: run-unit-tests-node-18
+    tags:
+      - unit-tests
+    commands:
+      - command: expansions.update
+        type: setup
+        params:
+          updates:
+            - {key: NODE_LTS_VERSION, value: '18'}
+            - {key: NPM_VERSION, value: latest}
+      - func: install dependencies
+      - func: run unit tests
+  - name: run-unit-tests-node-20
+    tags:
+      - unit-tests
+    commands:
+      - command: expansions.update
+        type: setup
+        params:
+          updates:
+            - {key: NODE_LTS_VERSION, value: '20'}
+            - {key: NPM_VERSION, value: latest}
+      - func: install dependencies
+      - func: run unit tests
   - name: run-lint-checks
     tags:
-      - run-lint-checks
+      - lint-checks
     commands:
       - command: expansions.update
         type: setup
@@ -2996,6 +3020,7 @@ tasks:
   - name: check-types-typescript-next
     tags:
       - check-types-typescript-next
+      - typescript-compilation
     commands:
       - command: expansions.update
         type: setup
@@ -3009,6 +3034,7 @@ tasks:
   - name: compile-driver-typescript-current
     tags:
       - compile-driver-typescript-current
+      - typescript-compilation
     commands:
       - command: expansions.update
         type: setup
@@ -3022,6 +3048,7 @@ tasks:
   - name: check-types-typescript-current
     tags:
       - check-types-typescript-current
+      - typescript-compilation
     commands:
       - command: expansions.update
         type: setup
@@ -3035,6 +3062,7 @@ tasks:
   - name: check-types-typescript-4.1.6
     tags:
       - check-types-typescript-4.1.6
+      - typescript-compilation
     commands:
       - command: expansions.update
         type: setup
@@ -4479,12 +4507,9 @@ buildvariants:
     display_name: lint
     run_on: rhel80-large
     tasks:
-      - run-unit-tests
-      - run-lint-checks
-      - check-types-typescript-next
-      - compile-driver-typescript-current
-      - check-types-typescript-current
-      - check-types-typescript-4.1.6
+      - .unit-tests
+      - .lint-checks
+      - .typescript-compilation
   - name: generate-combined-coverage
     display_name: Generate Combined Coverage
     run_on: rhel80-large

.evergreen/generate_evergreen_tasks.js

@@ -489,24 +489,30 @@ BUILD_VARIANTS.push({
   tasks: ['test-rapid-server']
 });
 
-// singleton build variant for linting
-SINGLETON_TASKS.push(
-  ...[
-    {
-      name: 'run-unit-tests',
-      tags: ['run-unit-tests'],
+const unitTestTasks = Array.from((function* () {
+  for (const { versionNumber: NODE_LTS_VERSION, npmVersion: NPM_VERSION } of versions) {
+    yield {
+      name: `run-unit-tests-node-${NODE_LTS_VERSION}`,
+      tags: ['unit-tests'],
       commands: [
         updateExpansions({
-          NODE_LTS_VERSION: LOWEST_LTS,
-          NPM_VERSION: 9
+          NODE_LTS_VERSION,
+          NPM_VERSION
         }),
         { func: 'install dependencies' },
         { func: 'run unit tests' }
       ]
-    },
+    }
+  }
+})())
+
+// singleton build variant for linting
+SINGLETON_TASKS.push(
+  ...[
+    ...unitTestTasks,
     {
       name: 'run-lint-checks',
-      tags: ['run-lint-checks'],
+      tags: ['lint-checks'],
       commands: [
         updateExpansions({
           NODE_LTS_VERSION: LOWEST_LTS,
@@ -526,7 +532,7 @@ function* makeTypescriptTasks() {
     if (TS_VERSION !== '4.1.6' && TS_VERSION !== 'next') {
       yield {
         name: `compile-driver-typescript-${TS_VERSION}`,
-        tags: [`compile-driver-typescript-${TS_VERSION}`],
+        tags: [`compile-driver-typescript-${TS_VERSION}`, 'typescript-compilation'],
         commands: [
           updateExpansions({
             NODE_LTS_VERSION: LOWEST_LTS,
@@ -541,7 +547,7 @@ function* makeTypescriptTasks() {
 
     yield {
       name: `check-types-typescript-${TS_VERSION}`,
-      tags: [`check-types-typescript-${TS_VERSION}`],
+      tags: [`check-types-typescript-${TS_VERSION}`, 'typescript-compilation'],
       commands: [
         updateExpansions({
           NODE_LTS_VERSION: LOWEST_LTS,
@@ -555,7 +561,7 @@ function* makeTypescriptTasks() {
   }
   return {
     name: 'run-typescript-next',
-    tags: ['run-typescript-next'],
+    tags: ['run-typescript-next', 'typescript-compilation'],
     commands: [
       updateExpansions({
         NODE_LTS_VERSION: LOWEST_LTS,
@@ -572,9 +578,9 @@ BUILD_VARIANTS.push({
   display_name: 'lint',
   run_on: DEFAULT_OS,
   tasks: [
-    'run-unit-tests',
-    'run-lint-checks',
-    ...Array.from(makeTypescriptTasks()).map(({ name }) => name)
+    '.unit-tests',
+    '.lint-checks',
+    '.typescript-compilation'
   ]
 });
 

test/unit/assorted/polling_srv_records_for_mongos_discovery.prose.test.ts

@@ -1,5 +1,6 @@
 import { expect } from 'chai';
 import * as dns from 'dns';
+import { coerce } from 'semver';
 import * as sinon from 'sinon';
 
 import {
@@ -44,6 +45,18 @@ interface ShardedClusterMocks {
 // TODO(NODE-3773): Make use of the shared driver's DNS records
 // TODO(NODE-3773): Implement tests 6-9
 describe('Polling Srv Records for Mongos Discovery', () => {
+  beforeEach(function () {
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const test = this.currentTest!;
+
+    const { major } = coerce(process.version);
+    test.skipReason =
+      major === 18 || major === 20
+        ? 'TODO(NODE-5666): fix failing unit tests on Node18'
+        : undefined;
+
+    if (test.skipReason) this.skip();
+  });
   describe('SRV polling prose cases 1-5', () => {
     const SRV_HOST = 'darmok.tanagra.com';
     const context: Record<string, any> = {};

test/unit/connection_string.spec.test.ts

@@ -1,3 +1,5 @@
+import { coerce } from 'semver';
+
 import { loadSpecTests } from '../spec';
 import { executeUriValidationTest } from '../tools/uri_spec_runner';
 
@@ -12,6 +14,23 @@ const skipTests = [
 describe('Connection String spec tests', function () {
   const suites = loadSpecTests('connection-string');
 
+  beforeEach(function () {
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const test = this.currentTest!;
+
+    const { major } = coerce(process.version);
+    const skippedTests = [
+      'Invalid port (zero) with IP literal',
+      'Invalid port (zero) with hostname'
+    ];
+    test.skipReason =
+      major === 20 && skippedTests.includes(test.title)
+        ? 'TODO(NODE-5666): fix failing unit tests on Node18'
+        : undefined;
+
+    if (test.skipReason) this.skip();
+  });
+
   for (const suite of suites) {
     describe(suite.name, function () {
       for (const test of suite.tests) {

test/unit/sdam/monitor.test.ts

@@ -1,4 +1,5 @@
 import { expect } from 'chai';
+import { coerce } from 'semver';
 import * as sinon from 'sinon';
 import { setTimeout } from 'timers';
 
@@ -29,6 +30,26 @@ class MockServer {
 describe('monitoring', function () {
   let mockServer;
 
+  beforeEach(function () {
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const test = this.currentTest!;
+
+    const { major } = coerce(process.version);
+    const failingTests = [
+      'should connect and issue an initial server check',
+      'should ignore attempts to connect when not already closed',
+      'should not initiate another check if one is in progress',
+      'should not close the monitor on a failed heartbeat',
+      'should upgrade to hello from legacy hello when initial handshake contains helloOk'
+    ];
+    test.skipReason =
+      (major === 18 || major === 20) && failingTests.includes(test.title)
+        ? 'TODO(NODE-5666): fix failing unit tests on Node18'
+        : undefined;
+
+    if (test.skipReason) this.skip();
+  });
+
   after(() => mock.cleanup());
   beforeEach(function () {
     return mock.createServer().then(server => (mockServer = server));

test/unit/sdam/topology.test.js

@@ -15,6 +15,7 @@ const { TopologyType } = require('../../mongodb');
 const { SrvPoller, SrvPollingEvent } = require('../../mongodb');
 const { getSymbolFrom, topologyWithPlaceholderClient } = require('../../tools/utils');
 const { LEGACY_NOT_WRITABLE_PRIMARY_ERROR_MESSAGE } = require('../../mongodb');
+const { coerce } = require('semver');
 
 describe('Topology (unit)', function () {
   let client, topology;
@@ -292,6 +293,16 @@ describe('Topology (unit)', function () {
     });
 
     it('should encounter a server selection timeout on garbled server responses', function (done) {
+      const test = this.test;
+
+      const { major } = coerce(process.version);
+      test.skipReason =
+        major === 18 || major === 20
+          ? 'TODO(NODE-5666): fix failing unit tests on Node18'
+          : undefined;
+
+      if (test.skipReason) this.skip();
+
       const server = net.createServer();
       const p = Promise.resolve();
       let unexpectedError, expectedError;