ci(NODE-5615): unit test on Node18 and Node20 #3879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-5615
branch
from
bcc50d8 to
b509011
Compare
nbbeeken
suggested changes
Oct 4, 2023
nbbeeken
added
the
Primary Review
nbbeeken
approved these changes
Oct 4, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
We now unit test against Node18 and Node20 in CI. The changes are set up so that when a new LTS node version is added, we will automatically start testing against it.
I also did a small cleanup and converted the
lintvariant in CI to use evergreen tags, not hard-coded task names.The failing tests on Node18 and Node20 are skipped and NODE-5666 was filed to fix them.
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript