Skip to content

test(NODE-4565): skip Network error on Monitor check #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 19, 2022

Description

What is changing?

Skips a test that leaks a socket, we'll look into fixing it in a follow up, or replacing it with a unified version of the same test.

What is the motivation for this change?

Green trees 🌲

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review August 19, 2022 14:47
@baileympearson baileympearson merged commit 5d004f2 into main Aug 19, 2022
@baileympearson baileympearson deleted the NODE-4565/skip-Network-error-on-Monitor-check branch August 19, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants