Skip to content

ci(NODE-5313): change windows hosts to vsCurrent #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

ci(NODE-5313): change windows hosts to vsCurrent #3690

merged 1 commit into from
May 30, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented May 26, 2023 •
edited
Loading

Description

What is changing?

  • vs2019 -> vsCurrent
  • Gathered all the hosts into constants, with the intention to make a quick reference of which hosts we depend on

#3687

Is there new documentation needed for these changes?

What is the motivation for this change?

vsCurrent is a more recent OS and is better maintained

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review May 26, 2023 20:29
@nbbeeken nbbeeken mentioned this pull request May 26, 2023
Merged
5 tasks
@durran durran self-assigned this May 30, 2023
@durran durran added the Team Review Needs review from team label May 30, 2023
@durran durran merged commit 261199f into 4.x May 30, 2023
@durran durran deleted the NODE-5313-windows-4.x branch May 30, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran