Skip to content

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Copied the release from main workflow
  • Changed the branch trigger to 4.x
  • Changed default-branch to 4.x
  • added npm tag "4x"
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Automagic releases for 4.x

Release Highlight

Double check the following

  • [/] Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • [/] Changes are covered by tests
  • [/] New TODOs have a related JIRA ticket

@nbbeeken
Copy link
Contributor Author

Depends on #3747, that PR just copies the scripts to 4.x so that release_notes workflow has access to them when it checks out the release PR which was branched from 4.x not main

@durran durran self-assigned this Jul 3, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 3, 2023
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as regular release workflow with branches changed.

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 3, 2023
@durran durran merged commit dda4ec0 into main Jul 3, 2023
@durran durran deleted the NODE-5382-release-4.x branch July 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants