Skip to content

test(NODE-5733): remove at() usage #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2023
Merged

test(NODE-5733): remove at() usage #3900

merged 2 commits into from
Nov 9, 2023

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Remove at usage

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Fix node 14

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@mongodb mongodb deleted a comment from baileympearson Nov 6, 2023
@nbbeeken nbbeeken removed the request for review from baileympearson November 6, 2023 19:03
@nbbeeken nbbeeken changed the title test: remove at usage test: remove at() usage Nov 6, 2023
@nbbeeken nbbeeken changed the title test: remove at() usage test(NODE-5733): remove at() usage Nov 6, 2023
aditi-khare-mongoDB
aditi-khare-mongoDB approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbbeeken nbbeeken added Primary Review In Review with primary reviewer, not yet ready for team's eyes Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 8, 2023
@durran durran merged commit a58f8ee into 5.x Nov 9, 2023
@durran durran deleted the chore-fix-at branch November 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

+1 more reviewer

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aditi-khare-mongoDB aditi-khare-mongoDB

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nbbeeken @durran @aditi-khare-mongoDB