Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Nov 9, 2023

Description

Updates the driver to use the new tools data lake test scripts so we don't occasionally fail when the DL team makes breaking changes to their configs. They now own the drivers config on the image and will update them when they make breaking changes.

https://spruce.mongodb.com/task/mongo_node_driver_ubuntu2204_test_atlas_data_lake_test_atlas_data_lake_patch_3934465ef4dbc37d8f3942d8ffba5905ed0d509a_654d4a2a2a60ed5a5a28e98e_23_11_09_21_07_55?execution=0&sortBy=STATUS&sortDir=ASC

What is changing?

  • Updates our evergreen config to use the new pull-mongohouse-image.sh and run-mongohouse-image.sh scripts.
  • Moves Data Lake tests to an Ubuntu 22 variant as these will not work on RHEL8
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5738

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review November 10, 2023 15:09
@nbbeeken nbbeeken self-requested a review November 10, 2023 19:19
@nbbeeken nbbeeken self-assigned this Nov 10, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 10, 2023
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADL fixed, other failures known & unrelated

@nbbeeken nbbeeken merged commit c698918 into 4.x Nov 10, 2023
@nbbeeken nbbeeken deleted the NODE-5738 branch November 10, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants