-
Notifications
You must be signed in to change notification settings - Fork 54
Doc Suggestions: Glossary, Dev Guide, and Diagram Idea #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added glossary, getting started tips, and diagram suggestion
WalkthroughA new "Suggested Improvements" section was added to the documentation, outlining proposals for enhancing clarity and usability. The suggestions include adding a glossary, a step-by-step getting started guide, a visual architecture diagram, and correcting a broken link. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/about-morph/0-user-navigation-page.md (4)
88-89
: Consider relocating contributor-focused suggestions
The “🛠 Suggested Improvements” section is aimed at contributors rather than end-users. To keep the user navigation page clean, consider moving these proposals into a dedicatedCONTRIBUTING.md
or developer guide.
90-96
: Link to a centralized glossary
Rather than listing terms inline, create a standalonedocs/glossary.md
and hyperlink each term. This improves navigation and keeps definitions in one place.
97-103
: Avoid duplicating Getting Started content
There’s already a “Getting Started” section at lines 19–38. Merge these suggested steps into that existing section and replace the placeholders with actual links to/docs/quick-start/...
.
104-106
: Define placeholder for visual diagram
Specify where to store the architecture diagram (e.g.,assets/diagrams/morph-architecture.png
) or recommend using a Mermaid block. This guidance will help contributors add the diagram consistently.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/about-morph/0-user-navigation-page.md
(1 hunks)
🔇 Additional comments (1)
docs/about-morph/0-user-navigation-page.md (1)
107-110
: Clarify and apply broken link fix
This file doesn’t include the Ethereum roadmap URL. Please point to the exact file and line where the broken link appears (likely indocs/about-morph/roadmap.md
) and update it tohttps://ethereum.org/en/roadmap/
.
Hey team! 👋
I added suggestions to improve the developer experience in your Morph docs, including:
Hope this helps polish the docs for new contributors
Summary by CodeRabbit