-
Notifications
You must be signed in to change notification settings - Fork 54
Update 2-development-setup.md #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Cleaned up the URLs by deleting the "/" at the end, and making it look uniform all throughout the doc. 2. Updated Holesky text to Hoodi text. 3. Updated the RPC URL table from Holesky to Hoodi. 4. Cleaned up typographical errors. 5. Updated Acquire Ether resource links (from Holesky to Hoodi).
WalkthroughDocumentation updates in a single Markdown file revise network terminology and resources from Holesky to Hoodi, including RPC endpoints, chain IDs, faucets, bridge, explorer links, and section wording (e.g., “development framework”). No code or API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
docs/build-on-morph/build-on-morph/2-development-setup.md (1)
115-121
: Consider updating commented-out Holesky references.The commented section still contains "holesky" in the Tendermint RPC URL. While this is not visible to users, updating it would maintain consistency throughout the file.
Apply this diff if you plan to keep these comments:
<!-- ### Tendermint Consensus Information -Tendermint RPC: https://rpc-consensus-holesky.morphl2.io +Tendermint RPC: https://rpc-consensus-hoodi.morphl2.io Tendermint RPC Documentation: https://docs.tendermint.com/v0.34/rpc/#/ -->
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/build-on-morph/build-on-morph/2-development-setup.md
(6 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/build-on-morph/build-on-morph/2-development-setup.md
104-104: Bare URL used
(MD034, no-bare-urls)
104-104: Bare URL used
(MD034, no-bare-urls)
107-107: Bare URL used
(MD034, no-bare-urls)
107-107: Bare URL used
(MD034, no-bare-urls)
173-173: Bare URL used
(MD034, no-bare-urls)
175-175: Bare URL used
(MD034, no-bare-urls)
177-177: Bare URL used
(MD034, no-bare-urls)
179-179: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (9)
docs/build-on-morph/build-on-morph/2-development-setup.md (9)
15-17
: URL formatting improved.Trailing slashes removed for consistency across framework links.
51-51
: Grammar fix applied."development framework" is the correct form.
96-96
: Network terminology updated correctly.The heading now reflects the Hoodi Testnet nomenclature.
111-111
: WebSocket endpoint updated correctly.The WSS URL now points to the Hoodi testnet RPC.
122-122
: Grammar fix applied consistently.The typo correction matches the earlier mainnet section heading.
133-133
: Hardhat configuration updated for Hoodi testnet.The RPC URL correctly points to the Hoodi endpoint.
161-161
: ethers.js provider configuration updated.The JSON-RPC provider URL correctly references the Hoodi testnet.
167-167
: Bridge URL and instructions updated correctly.The text now references the Hoodi bridge and testnet appropriately.
186-186
: Block explorer reference updated correctly.The text now accurately references the Hoodi Network and links to the correct Hoodi block explorer.
| Network Name | Morph Hoodi Testnet | Hoodi Testnet | | ||
| --- | --- | --- | | ||
| RPC URL | https://rpc-quicknode-holesky.morphl2.io| https://ethereum-holesky-rpc.publicnode.com/ | | ||
| Chain ID | 2810 | 17000 | | ||
| RPC URL | https://rpc-hoodi.morphl2.io| https://ethereum-hoodi-rpc.publicnode.com | | ||
| Chain ID | 2910 | 560048 | | ||
| Currency Symbol | ETH | ETH | | ||
| Block Explorer URL | https://explorer-holesky.morphl2.io/| https://holesky.etherscan.io/ | | ||
| Block Explorer URL | https://explorer-hoodi.morphl2.io| https://hoodi.etherscan.io | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap bare URLs in angle brackets.
The network configuration table contains bare URLs that should be wrapped in angle brackets per Markdown best practices.
Apply this diff:
-| Network Name | Morph Hoodi Testnet | Hoodi Testnet |
-| --- | --- | --- |
-| RPC URL | https://rpc-hoodi.morphl2.io| https://ethereum-hoodi-rpc.publicnode.com |
-| Chain ID | 2910 | 560048 |
-| Currency Symbol | ETH | ETH |
-| Block Explorer URL | https://explorer-hoodi.morphl2.io| https://hoodi.etherscan.io |
+| Network Name | Morph Hoodi Testnet | Hoodi Testnet |
+| --- | --- | --- |
+| RPC URL | <https://rpc-hoodi.morphl2.io> | <https://ethereum-hoodi-rpc.publicnode.com> |
+| Chain ID | 2910 | 560048 |
+| Currency Symbol | ETH | ETH |
+| Block Explorer URL | <https://explorer-hoodi.morphl2.io> | <https://hoodi.etherscan.io> |
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Network Name | Morph Hoodi Testnet | Hoodi Testnet | | |
| --- | --- | --- | | |
| RPC URL | https://rpc-quicknode-holesky.morphl2.io| https://ethereum-holesky-rpc.publicnode.com/ | | |
| Chain ID | 2810 | 17000 | | |
| RPC URL | https://rpc-hoodi.morphl2.io| https://ethereum-hoodi-rpc.publicnode.com | | |
| Chain ID | 2910 | 560048 | | |
| Currency Symbol | ETH | ETH | | |
| Block Explorer URL | https://explorer-holesky.morphl2.io/| https://holesky.etherscan.io/ | | |
| Block Explorer URL | https://explorer-hoodi.morphl2.io| https://hoodi.etherscan.io | | |
| Network Name | Morph Hoodi Testnet | Hoodi Testnet | | |
| ------------------ | ------------------------------------------------------------- | ---------------------------------------------- | | |
| RPC URL | <https://rpc-hoodi.morphl2.io> | <https://ethereum-hoodi-rpc.publicnode.com> | | |
| Chain ID | 2910 | 560048 | | |
| Currency Symbol | ETH | ETH | | |
| Block Explorer URL | <https://explorer-hoodi.morphl2.io> | <https://hoodi.etherscan.io> | |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
104-104: Bare URL used
(MD034, no-bare-urls)
104-104: Bare URL used
(MD034, no-bare-urls)
107-107: Bare URL used
(MD034, no-bare-urls)
107-107: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In docs/build-on-morph/build-on-morph/2-development-setup.md around lines 102 to
107, the Markdown table contains bare URLs; update each URL cell to be wrapped
in angle brackets (e.g. <https://rpc-hoodi.morphl2.io>) so Markdown renders them
safely and prevents auto-linking issues—apply this change to the RPC URL and
Block Explorer URL cells for both columns.
Hoodi ETH faucet websites: | ||
|
||
https://stakely.io/en/faucet/ethereum-holesky-testnet-eth | ||
https://stakely.io/faucet/ethereum-hoodi-testnet-eth | ||
|
||
https://faucet.quicknode.com/ethereum/holesky | ||
https://faucet.quicknode.com/ethereum/hoodi | ||
|
||
https://holesky-faucet.pk910.de/ | ||
https://hoodi-faucet.pk910.de | ||
|
||
https://cloud.google.com/application/web3/faucet/ethereum (needs a Google account) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap faucet URLs in angle brackets.
The bare URLs should be wrapped in angle brackets per Markdown best practices.
Apply this diff:
Hoodi ETH faucet websites:
-https://stakely.io/faucet/ethereum-hoodi-testnet-eth
+<https://stakely.io/faucet/ethereum-hoodi-testnet-eth>
-https://faucet.quicknode.com/ethereum/hoodi
+<https://faucet.quicknode.com/ethereum/hoodi>
-https://hoodi-faucet.pk910.de
+<https://hoodi-faucet.pk910.de>
-https://cloud.google.com/application/web3/faucet/ethereum (needs a Google account)
+<https://cloud.google.com/application/web3/faucet/ethereum> (needs a Google account)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Hoodi ETH faucet websites: | |
https://stakely.io/en/faucet/ethereum-holesky-testnet-eth | |
https://stakely.io/faucet/ethereum-hoodi-testnet-eth | |
https://faucet.quicknode.com/ethereum/holesky | |
https://faucet.quicknode.com/ethereum/hoodi | |
https://holesky-faucet.pk910.de/ | |
https://hoodi-faucet.pk910.de | |
https://cloud.google.com/application/web3/faucet/ethereum (needs a Google account) | |
Hoodi ETH faucet websites: | |
<https://stakely.io/faucet/ethereum-hoodi-testnet-eth> | |
<https://faucet.quicknode.com/ethereum/hoodi> | |
<https://hoodi-faucet.pk910.de> | |
<https://cloud.google.com/application/web3/faucet/ethereum> (needs a Google account) |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
173-173: Bare URL used
(MD034, no-bare-urls)
175-175: Bare URL used
(MD034, no-bare-urls)
177-177: Bare URL used
(MD034, no-bare-urls)
179-179: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In docs/build-on-morph/build-on-morph/2-development-setup.md around lines 171 to
179, the listed faucet URLs are plain text; wrap each URL in angle brackets
(<...>) so Markdown treats them as explicit links (e.g., replace each bare URL
line with the same URL enclosed in angle brackets), preserving the existing line
breaks and text.
|
||
|
||
Morph also offers a [Discord faucet](../../quick-start/3-faucet.md#morph-holesky-eth) to obtain Morph Holesky USDT & Morph Holesky ETH. | ||
Morph also offers a [Discord faucet](../../quick-start/3-faucet.md#morph-holesky-eth) to obtain Morph Hoodi USDT & Morph Hoodi ETH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete Holesky→Hoodi replacement.
Line 184 still references "Morph Holesky" which should be updated to "Morph Hoodi" to complete the network terminology migration.
Apply this diff:
-Morph also offers a [Discord faucet](../../quick-start/3-faucet.md#morph-holesky-eth) to obtain Morph Hoodi USDT & Morph Hoodi ETH.
+Morph also offers a [Discord faucet](../../quick-start/3-faucet.md#morph-hoodi-eth) to obtain Morph Hoodi USDT & Morph Hoodi ETH.
Note: The anchor link in the URL (#morph-holesky-eth
) should also be updated to #morph-hoodi-eth
to match the target section if it has been renamed in that file.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Morph also offers a [Discord faucet](../../quick-start/3-faucet.md#morph-holesky-eth) to obtain Morph Hoodi USDT & Morph Hoodi ETH. | |
Morph also offers a [Discord faucet](../../quick-start/3-faucet.md#morph-hoodi-eth) to obtain Morph Hoodi USDT & Morph Hoodi ETH. |
🤖 Prompt for AI Agents
In docs/build-on-morph/build-on-morph/2-development-setup.md around line 184,
the text still says "Morph Holesky" and links to an anchor "#morph-holesky-eth";
change the visible text to "Morph Hoodi" and update the URL anchor to
"#morph-hoodi-eth" so the wording and link match the network rename. Verify the
target file quick-start/3-faucet.md has the corresponding anchor name and update
that file if necessary to use "#morph-hoodi-eth" to avoid broken links.
Summary by CodeRabbit