-
Notifications
You must be signed in to change notification settings - Fork 54
Update 1-deploy-contract-on-morph.md #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Updated Holesky to Hoodi 2. Grammatical changes
WalkthroughRenames Holesky references to Hoodi across a single documentation page, updating testnet names, links (faucet, bridge, explorer/API), and tool narratives (Hardhat/Foundry). Adjusts wording and capitalization to align with Hoodi terminology. No code, API, or control-flow changes—documentation-only updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/build-on-morph/code-examples/1-deploy-contract-on-morph.md
(6 hunks)
🔇 Additional comments (6)
docs/build-on-morph/code-examples/1-deploy-contract-on-morph.md (6)
8-10
: LGTM! Introduction updated correctly.The testnet name has been properly updated to "Morph Hoodi Testnet" and the demo repository reference is clear.
36-36
: LGTM! Installation links are correct.The nodejs and yarn installation links point to official sources.
98-99
: LGTM! Explorer URLs updated consistently.The API and browser URLs correctly use the "hoodi" subdomain pattern.
119-119
: LGTM! Grammatical improvement.The phrase "Once successful" is grammatically correct and the explorer link is properly updated to Hoodi.
178-178
: LGTM! Consistent with Hardhat section.The success message maintains consistency with the Hardhat section and correctly links to the Hoodi explorer.
183-183
: LGTM! Closing message updated correctly.The thank you message properly references "Morph Hoodi Testnet" and provides appropriate support channel information.
Before you start deploying the contract, you need to request test tokens from a Hoodi faucet and use the | ||
[bridge](https://bridge-hoodi.morphl2.io) to transfer some test ETH from _Hodi_ to _Morph Hoodi_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix naming inconsistency: "Hodi" should be "Hoodi".
Line 14 references "Hodi" while the rest of the document consistently uses "Hoodi". This appears to be a typo.
Apply this diff to fix the inconsistency:
- [bridge](https://bridge-hoodi.morphl2.io) to transfer some test ETH from _Hodi_ to _Morph Hoodi_.
+ [bridge](https://bridge-hoodi.morphl2.io) to transfer some test ETH from _Hoodi_ to _Morph Hoodi_.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Before you start deploying the contract, you need to request test tokens from a Hoodi faucet and use the | |
[bridge](https://bridge-hoodi.morphl2.io) to transfer some test ETH from _Hodi_ to _Morph Hoodi_. | |
Before you start deploying the contract, you need to request test tokens from a Hoodi faucet and use the | |
[bridge](https://bridge-hoodi.morphl2.io) to transfer some test ETH from _Hoodi_ to _Morph Hoodi_. |
🤖 Prompt for AI Agents
In docs/build-on-morph/code-examples/1-deploy-contract-on-morph.md around lines
13 to 14, there is a naming inconsistency where "_Hodi_" is used instead of the
correct "_Hoodi_"; update the typo so the sentence consistently reads "Hoodi"
(e.g., replace "Hodi" with "Hoodi") to match the rest of the document.
} | ||
``` | ||
Then run the following command to deploy the contract on the Morph Holesky Testnet. This will run the deployment script that set the initialing parameters, you can edit the script in scripts/deploy.ts | ||
Then run the following command to deploy the contract on the Morph Hoodi Testnet. This will run the deployment script that set the initialing parameters, you can edit the script in scripts/deploy.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammatical error: "initialing" should be "initial".
The word "initialing" is not standard English in this context. It should be "initial" (adjective) or "initialization" (noun).
Apply this diff to fix the grammar:
-Then run the following command to deploy the contract on the Morph Hoodi Testnet. This will run the deployment script that set the initialing parameters, you can edit the script in scripts/deploy.ts
+Then run the following command to deploy the contract on the Morph Hoodi Testnet. This will run the deployment script that sets the initial parameters, you can edit the script in scripts/deploy.ts
Note: Also fixed "set" → "sets" for subject-verb agreement.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Then run the following command to deploy the contract on the Morph Hoodi Testnet. This will run the deployment script that set the initialing parameters, you can edit the script in scripts/deploy.ts | |
Then run the following command to deploy the contract on the Morph Hoodi Testnet. This will run the deployment script that sets the initial parameters, you can edit the script in scripts/deploy.ts |
🤖 Prompt for AI Agents
In docs/build-on-morph/code-examples/1-deploy-contract-on-morph.md around line
74, fix the grammar in the sentence "This will run the deployment script that
set the initialing parameters, you can edit the script in scripts/deploy.ts" by
changing "set" to "sets" for correct subject-verb agreement and replacing
"initialing" with "initial" (or "initialization" if you prefer the noun form),
ensuring the sentence reads clearly (e.g., "...that sets the initial parameters;
you can edit the script in scripts/deploy.ts").
Summary by CodeRabbit