Skip to content

update mpt7b instruct ft commit #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

update mpt7b instruct ft commit #375

wants to merge 5 commits into from

Conversation

RR4787
Copy link
Contributor

@RR4787 RR4787 commented Jun 20, 2023 •
edited
Loading

Update yaml commit and pin the HF model commit

@RR4787 RR4787 requested a review from margaretqian June 20, 2023 21:31
@RR4787 RR4787 requested review from ajaysaini725 and vchiley June 20, 2023 23:39
margaretqian
margaretqian reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@margaretqian margaretqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the merge conflict is probably due to the file name changing

examples/inference-deployments/mpt/mpt_7b_ft_handler.py

LOCAL_CHECKPOINT_DIR = '/tmp/mpt'
LOCAL_MODEL_PATH = os.path.join(LOCAL_CHECKPOINT_DIR, 'local_model')
HF_COMMIT = 'bbe7a55d70215e16c00c1825805b81e4badb57d7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be passed in from the input yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vchiley vchiley Awaiting requested review from vchiley

@ajaysaini725 ajaysaini725 Awaiting requested review from ajaysaini725

1 more reviewer

@margaretqian margaretqian margaretqian left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RR4787 @margaretqian