-
Notifications
You must be signed in to change notification settings - Fork 217
Add tutorial for How to Use OMPL Constrained Planning #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for How to Use OMPL Constrained Planning #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The position constraints generally work great! I have not gotten a successful plan with the orientation constraints yet, though
doc/how_to_guides/ompl_constrained_planning/ompl_constrained_planning.rst
Outdated
Show resolved
Hide resolved
Just as I post that, I see a successful plan with the orientation constraint. So it is possible ;) |
doc/how_to_guides/ompl_constrained_planning/ompl_constrained_planning.rst
Outdated
Show resolved
Hide resolved
doc/how_to_guides/ompl_constrained_planning/src/ompl_constrained_planning_tutorial.cpp
Outdated
Show resolved
Hide resolved
doc/how_to_guides/ompl_constrained_planning/src/ompl_constrained_planning_tutorial.cpp
Outdated
Show resolved
Hide resolved
This pull request is in conflict. Could you fix it @stephanie-eng? |
2519a11
to
ac1e89c
Compare
4301fe2
to
c6ff4e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tutorial! I like the second part a lot that highlights the details between the constraint types
I had issues running it because when I launched the tutorial I got this error:
[ERROR] [ros2_control_node-6]: process has died [pid 211888, exit code -11, cmd '/root/ws_moveit/install/controller_manager/lib/controller_manager/ros2_control_node --ros-args --params-file /tmp/launch_params_r4wggd5i --params-file /root/ws_moveit/install/moveit_resources_panda_moveit_config/share/moveit_resources_panda_moveit_config/config/ros2_controllers.yaml'].
Do you have an idea what causes this?
doc/how_to_guides/using_ompl_constrained_planning/ompl_constrained_planning.rst
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,293 @@ | |||
Using OMPL Constrained Planning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is in the HOW TO section consider renaming it into How to use OMPL constrained planning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that originally, but I was thinking that if every document under How to is called "How To ..." it's a bit repetitive and redundant. I don't have a strong opinion on this, though, so happy to change if we prefer the consistency. @tylerjw do you have a preference for naming scheme in the How To section?
doc/how_to_guides/using_ompl_constrained_planning/ompl_constrained_planning.rst
Show resolved
Hide resolved
@@ -9,3 +9,4 @@ These how-to guides will help you quickly solve specific problems using MoveIt. | |||
how_to_guide | |||
how_to_generate_api_doxygen_locally | |||
how_to_setup_docker_containers_in_ubuntu | |||
using_ompl_constrained_planning/ompl_constrained_planning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this to how to ...
doc/how_to_guides/using_ompl_constrained_planning/ompl_constrained_planning.rst
Show resolved
Hide resolved
This pull request is in conflict. Could you fix it @stephanie-eng? |
fef1a95
to
1e9546f
Compare
* Add tutorial for How to Use OMPL Constrained Planning * Reorganize code, port comments from original, use equality constraints * Update tutorial text and media, reorganize files, and clean up * Update .repos file for RViz Visual Tools * Remove outdated video link * Add description and links for projection evaluator Co-authored-by: AndyZe <[email protected]> (cherry picked from commit 2db5773) # Conflicts: # .github/upstream.repos # CMakeLists.txt # moveit2_tutorials.repos
* Add tutorial for How to Use OMPL Constrained Planning * Reorganize code, port comments from original, use equality constraints * Update tutorial text and media, reorganize files, and clean up * Update .repos file for RViz Visual Tools * Remove outdated video link * Add description and links for projection evaluator Co-authored-by: AndyZe <[email protected]> (cherry picked from commit 2db5773)
* Add tutorial for How to Use OMPL Constrained Planning * Reorganize code, port comments from original, use equality constraints * Update tutorial text and media, reorganize files, and clean up * Update .repos file for RViz Visual Tools * Remove outdated video link * Add description and links for projection evaluator Co-authored-by: AndyZe <[email protected]> (cherry picked from commit 2db5773)
* Add tutorial for How to Use OMPL Constrained Planning * Reorganize code, port comments from original, use equality constraints * Update tutorial text and media, reorganize files, and clean up * Update .repos file for RViz Visual Tools * Remove outdated video link * Add description and links for projection evaluator Co-authored-by: AndyZe <[email protected]> (cherry picked from commit 2db5773)
* Add tutorial for How to Use OMPL Constrained Planning * Reorganize code, port comments from original, use equality constraints * Update tutorial text and media, reorganize files, and clean up * Update .repos file for RViz Visual Tools * Remove outdated video link * Add description and links for projection evaluator Co-authored-by: AndyZe <[email protected]> (cherry picked from commit 2db5773)
* Add tutorial for How to Use OMPL Constrained Planning * Reorganize code, port comments from original, use equality constraints * Update tutorial text and media, reorganize files, and clean up * Update .repos file for RViz Visual Tools * Remove outdated video link * Add description and links for projection evaluator Co-authored-by: AndyZe <[email protected]> (cherry picked from commit 2db5773)
* Add tutorial for How to Use OMPL Constrained Planning * Reorganize code, port comments from original, use equality constraints * Update tutorial text and media, reorganize files, and clean up * Update .repos file for RViz Visual Tools * Remove outdated video link * Add description and links for projection evaluator Co-authored-by: AndyZe <[email protected]> (cherry picked from commit 2db5773) Co-authored-by: Stephanie Eng <[email protected]>
Description
Update tutorial for OMPL Constrained Planning. This PR both ports the existing tutorial to MoveIt2 and adds a new section for OMPL orientation constraints (depends on moveit/moveit2#1273).
Also depends on PickNikRobotics/rviz_visual_tools#221 for a helper method for drawing a plane.
Tasks:
To launch the example:
ros2 launch moveit2_tutorials ompl_constrained_planning_tutorial.launch.py