Skip to content

Add tutorial for How to Use OMPL Constrained Planning #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stephanie-eng
Copy link
Contributor

@stephanie-eng stephanie-eng commented May 24, 2022

Description

Update tutorial for OMPL Constrained Planning. This PR both ports the existing tutorial to MoveIt2 and adds a new section for OMPL orientation constraints (depends on moveit/moveit2#1273).

Also depends on PickNikRobotics/rviz_visual_tools#221 for a helper method for drawing a plane.


Tasks:

  • Add orientation constraint example
  • Transfer existing examples from MoveIt1 to MoveIt2
  • Update documentation
  • Delete any irrelevant files

To launch the example:

ros2 launch moveit2_tutorials ompl_constrained_planning_tutorial.launch.py

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The position constraints generally work great! I have not gotten a successful plan with the orientation constraints yet, though

@AndyZe
Copy link
Member

AndyZe commented May 25, 2022

Just as I post that, I see a successful plan with the orientation constraint. So it is possible ;)

@mergify
Copy link

mergify bot commented May 27, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@stephanie-eng stephanie-eng force-pushed the seng/ompl-constrained-planning-update branch from 2519a11 to ac1e89c Compare May 27, 2022 22:27
@stephanie-eng stephanie-eng force-pushed the seng/ompl-constrained-planning-update branch 6 times, most recently from 4301fe2 to c6ff4e0 Compare May 31, 2022 21:23
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tutorial! I like the second part a lot that highlights the details between the constraint types

I had issues running it because when I launched the tutorial I got this error:

[ERROR] [ros2_control_node-6]: process has died [pid 211888, exit code -11, cmd '/root/ws_moveit/install/controller_manager/lib/controller_manager/ros2_control_node --ros-args --params-file /tmp/launch_params_r4wggd5i --params-file /root/ws_moveit/install/moveit_resources_panda_moveit_config/share/moveit_resources_panda_moveit_config/config/ros2_controllers.yaml'].

Do you have an idea what causes this?

@@ -0,0 +1,293 @@
Using OMPL Constrained Planning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is in the HOW TO section consider renaming it into How to use OMPL constrained planning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that originally, but I was thinking that if every document under How to is called "How To ..." it's a bit repetitive and redundant. I don't have a strong opinion on this, though, so happy to change if we prefer the consistency. @tylerjw do you have a preference for naming scheme in the How To section?

@@ -9,3 +9,4 @@ These how-to guides will help you quickly solve specific problems using MoveIt.
how_to_guide
how_to_generate_api_doxygen_locally
how_to_setup_docker_containers_in_ubuntu
using_ompl_constrained_planning/ompl_constrained_planning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename this to how to ...

@stephanie-eng stephanie-eng marked this pull request as ready for review June 7, 2022 14:09
@mergify
Copy link

mergify bot commented Jun 7, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@stephanie-eng stephanie-eng force-pushed the seng/ompl-constrained-planning-update branch from fef1a95 to 1e9546f Compare June 9, 2022 15:20
@moveit moveit deleted a comment from mergify bot Jun 17, 2022
@AndyZe AndyZe merged commit 2db5773 into moveit:main Jun 29, 2022
@tylerjw tylerjw added the backport-humble This label signals Mergify to backport this PR to Humble label Jul 22, 2022
mergify bot pushed a commit that referenced this pull request Jul 22, 2022
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <[email protected]>
(cherry picked from commit 2db5773)

# Conflicts:
#	.github/upstream.repos
#	CMakeLists.txt
#	moveit2_tutorials.repos
stephanie-eng added a commit that referenced this pull request May 12, 2023
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <[email protected]>
(cherry picked from commit 2db5773)
stephanie-eng added a commit that referenced this pull request May 12, 2023
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <[email protected]>
(cherry picked from commit 2db5773)
stephanie-eng added a commit that referenced this pull request May 12, 2023
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <[email protected]>
(cherry picked from commit 2db5773)
stephanie-eng added a commit that referenced this pull request May 12, 2023
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <[email protected]>
(cherry picked from commit 2db5773)
stephanie-eng added a commit that referenced this pull request May 12, 2023
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <[email protected]>
(cherry picked from commit 2db5773)
stephanie-eng added a commit that referenced this pull request May 12, 2023
* Add tutorial for How to Use OMPL Constrained Planning

* Reorganize code, port comments from original, use equality constraints

* Update tutorial text and media, reorganize files, and clean up

* Update .repos file for RViz Visual Tools

* Remove outdated video link

* Add description and links for projection evaluator

Co-authored-by: AndyZe <[email protected]>
(cherry picked from commit 2db5773)

Co-authored-by: Stephanie Eng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label signals Mergify to backport this PR to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants