Skip to content

Update the servo tutorial for new pkg/topic names #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Update the servo tutorial for new pkg/topic names #508

merged 2 commits into from
Sep 11, 2020

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Jul 21, 2020

No description provided.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndyZe
Copy link
Member Author

AndyZe commented Sep 11, 2020

it's embarrassing that it has taken so long to get this PR merged

@AndyZe
Copy link
Member Author

AndyZe commented Sep 11, 2020

@rhaschke do you have any suggestions for how we can get these things merged faster?

@v4hn v4hn merged commit 1d64f5b into moveit:master Sep 11, 2020
@v4hn
Copy link
Contributor

v4hn commented Sep 11, 2020

it's embarrassing that it has taken so long to get this PR merged

True. The same is true for many unmerged PRs in main moveit and here though.
One thing you can do to move things faster is by reviewing and providing cleanup patches for other requests to support maintenance in other places as well as ping specific people to review/merge.

In this case I skipped the PR initially and nothing pushed me back to it since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants