Update the firware binary to work with latest cc3200-rs #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @dhylands |
dhylands
reviewed
Nov 28, 2016
| } | ||
|
|
||
| pub const SENSOR_READING_COUNT: u32 = 10; | ||
| pub const SERVER_URL: &'static str = "http://10.252.33.211:8000/endpoint"; |
There was a problem hiding this comment.
nit: no newline at end of file
| @@ -9,5 +9,6 @@ export PATH=/home/travis/.cargo/bin:$PATH | |||
| rustup default nightly | |||
| rustup component add rust-src | |||
| cargo install xargo | |||
| cp src/config.rs.sample src/config.rs | |||
There was a problem hiding this comment.
That seems like a reasonable way to do it in cc3200-rs as well (and addresses your concern about checking the file in accidentally).
|
|
||
| for _ in 0..config::SENSOR_READING_COUNT { | ||
| let temperature: u32 = (temp_sensor.get_temperature().unwrap() * 10.0) as u32; | ||
| info!("Feels like {}.{} C", temperature / 10, temperature % 10); |
There was a problem hiding this comment.
nit: This will report interesting results with a negative temperature :)
| info!("Received {}", | ||
| response.body.read_string_to_end(&mut buffer).unwrap()); | ||
| CurrentTask::delay(Duration::ms(1000)) | ||
| } |
There was a problem hiding this comment.
I don't see where this actually sends a temperature to the server.
|
@dhylands I addressed comments and pinned Rustc to the same version as in cc3200-rs. That fixed the unrelated cargo issue which is rust-lang/cargo#3340 |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR are: