Force all /users/ URLs to be served by addons-server #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
approved these changes
Mar 9, 2017
src/amo/routes.js
Outdated
| {/* These user routes are to make the proxy serve each URL from */} | ||
| {/* addons-server until we can fix the :visibleAddonType route below. */} | ||
| {/* https://github.com/mozilla/addons-frontend/issues/2029 */} | ||
| <Route path="users/edit/" component={NotFound} /> |
There was a problem hiding this comment.
I wonder if this should have a placeholder since there's quite a lot of options for other urls under users/ one could hit: https://github.com/mozilla/addons-server/blob/master/src/olympia/users/urls.py#L20
kumar303
changed the title
kumar303
changed the title
kumar303
added a commit
that referenced
this pull request
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround for mozilla/addons#10234
The real fix will arrive in mozilla/addons-server#4890