Skip to content

Revert "Force all /users/ URLs to be served by addons-server (#2034)" #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/amo/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@ export default (
<IndexRoute component={Home} />
<Route path="addon/:slug/" component={DetailPage} />
<Route path="addon/:addonSlug/reviews/" component={AddonReviewList} />
{/* These user routes are to make the proxy serve each URL from */}
{/* addons-server until we can fix the :visibleAddonType route below. */}
{/* https://github.com/mozilla/addons-frontend/issues/2029 */}
{/* We are mimicing these URLs: https://github.com/mozilla/addons-server/blob/master/src/olympia/users/urls.py#L20 */}
<Route path="users/:userAction/" component={NotFound} />
{/* Hack to make the proxy serve this URL from addons-server */}
{/* https://github.com/mozilla/addons-frontend/issues/1975 */}
<Route path="user/:user/" component={NotFound} />
<Route path=":visibleAddonType/categories/" component={CategoryList} />
Expand Down
20 changes: 0 additions & 20 deletions tests/server/amo/TestViews.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,24 +66,4 @@ describe('AMO GET Requests', () => {
it('should respond with a 404 to user pages', () => request(app)
.get('/en-US/firefox/user/some-user/')
.expect(404));

it('should respond with a 404 to the user edit page', () => request(app)
.get('/en-US/firefox/users/edit/')
.expect(404));

it('should respond with a 404 to a specific user edit', () => request(app)
.get('/en-US/firefox/users/edit/1234/')
.expect(404));

it('should respond with a 404 to user unsubscribe actions', () => request(app)
.get('/en-US/firefox/users/unsubscribe/token/signature/permission/')
.expect(404));

it('should respond with a 404 to deleting a user photo', () => request(app)
.get('/en-US/firefox/users/delete_photo/1234/')
.expect(404));

it('should respond with a 404 to any user action', () => request(app)
.get('/en-US/firefox/users/login/')
.expect(404));
});