-
Notifications
You must be signed in to change notification settings - Fork 160
Fix TODO on clippy false positive warning #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
edmundoferreira
added a commit
to edmundoferreira/grcov
that referenced
this issue
Mar 9, 2023
- fix all https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - fix all https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map - allow https://rust-lang.github.io/rust-clippy/master/index.html#manual_filter since it's a false positive that is already fixed upstream and will be present on next clippy release see mozilla#980
Merged
marco-c
pushed a commit
that referenced
this issue
Mar 9, 2023
- fix all https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow - fix all https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map - allow https://rust-lang.github.io/rust-clippy/master/index.html#manual_filter since it's a false positive that is already fixed upstream and will be present on next clippy release see #980
edmundoferreira
added a commit
to edmundoferreira/grcov
that referenced
this issue
Mar 16, 2023
- fixed upstream and release on rust 1.6.8 Closes mozilla#980
edmundoferreira
added a commit
to edmundoferreira/grcov
that referenced
this issue
Mar 16, 2023
- fix upstream and release on rust 1.6.8 Closes mozilla#980
marco-c
pushed a commit
that referenced
this issue
Mar 16, 2023
- fix upstream and release on rust 1.6.8 Closes #980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently github check like https://github.com/mozilla/grcov/actions/runs/4345920963/jobs/7591298097
However the clippy suggestion with
.filter(|&output_path| output_path.is_dir())
will not produce the desired result since currentlyhas
else
code path need to generate apanic!()
if the output path is not a directory.This clippy behaviour has been fixed on rust-lang/rust-clippy#10091 but unfortunately it's not yet released.
As a temporary work around we ignore the clippy warning by adding
#[allow(clippy::manual_filter)]
to the code block.This should be removed once the upstream fix to clippy is released
And remove TODO in Originally posted by @marco-c in #979 (comment)
The text was updated successfully, but these errors were encountered: