Skip to content

Also allow padding at the end of ctts boxes #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

torokati44
Copy link
Contributor

This was necessary to successfully parse the following file:
https://www.mea-culpa.at/02_videos/gesch_175_580x432px_12fps_300kbit.f4v

It has 7080 bytes of extra stuff in its ctts box after the given number of sample counts and offsets.

Other media players and demuxers (like VLC or MP4Box.js) had no problem with this particular file.

I copied the call and comment from other similar box reader functions nearby.

@kinetiknz
Copy link
Collaborator

kinetiknz commented May 15, 2025

Thanks! This seems reasonable, but I think it'd be good to only allow this when the parser is not in strict mode. I've adjusted your change to account for that and landed it in 49fc621 and 214b5ac.

@kinetiknz kinetiknz closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants