Add a third parameter to SourceNode.fromStringWithSourceMap
#105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use this PR in source-map-concat. |
| @@ -116,6 +118,9 @@ define(function (require, exports, module) { | |||
| aSourceMapConsumer.sources.forEach(function (sourceFile) { | |||
| var content = aSourceMapConsumer.sourceContentFor(sourceFile); | |||
| if (content) { | |||
| if (aRelativePath) { | |||
There was a problem hiding this comment.
Same as how I commented in the other PR, this should probably be:
if (aRelativePath != null) {
Just in case someone has a directory "0" for whatever reason.
There was a problem hiding this comment.
You didn’t say anything about this when the third parameter of .applySourceMap() was implemented. Isn’t the same issue present there?
|
Looks good, will merge with update mentioned above. Thanks! |
|
Fixed. |
|
Sweet, rebase and I'll merge :) (Sorry, I should have got to your PRs first so you didn't have to rebase all of them) |
An important use case for `SourceNode`s, and especially for `SourceNode.fromStringWithSourceMap`, is to concatenate files with source map support. This works well as long as all the input source maps and the concatenated file¿s source map are next to each other. That’s because any relative source paths in any input source map have to be rewritten to be relative to the concatenated file’s source map. This commit adds a third parameter to `SourceNode.fromStringWithSourceMap` allowing you to do this.
|
Rebased. |
|
Fixed in 6be13d9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An important use case for
SourceNodes, and especially forSourceNode.fromStringWithSourceMap, is to concatenate files withsource map support. This works well as long as all the input source maps
and the concatenated file¿s source map are next to each other. That’s
because any relative source paths in any input source map have to be
rewritten to be relative to the concatenated file’s source map. This
commit adds a third parameter to
SourceNode.fromStringWithSourceMapallowing you to do this.