Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Update the ios-webkit-debug-proxy for Windows to the latest version #221

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Conversation

artygus
Copy link
Contributor

@artygus artygus commented Jul 7, 2016

Should solve at least part of #199 issues for windows users

@jryans
Copy link
Contributor

jryans commented Jul 7, 2016

Thanks, I'll take a look at this soon!

@artygus, is this an updated build of your port? Can you update the commit hash in our README to match?

@artygus
Copy link
Contributor Author

artygus commented Jul 7, 2016

@jryans nope I decided to stick to mingw32 builds, because ios-webkit-debug-proxy depends on libimobiledevice lib and it doesn't look like libimobiledevice guys are interested in VS support. Every major update I had to look for another libimobiledevice "Visual Studio support fork" and add changes myself which is a bit annoying. This build is from google/ios-webkit-debug-proxy#124 which is in W.I.P. stage.

@jryans
Copy link
Contributor

jryans commented Jul 8, 2016

Well, this version does appear to work for me, but I did not notice any obvious changes from the existing version, which appears to also work for me at the moment. (It's been pretty temperamental in the past though, so it's hard for me to be sure.)

Are there specific issues that this newer build is meant to resolve that you know of?

@artygus
Copy link
Contributor Author

artygus commented Jul 8, 2016

tab switching should be less buggy at least, previous version doesn't really handle "_rpc_applicationUpdated" messages

@jryans
Copy link
Contributor

jryans commented Jul 12, 2016

@artygus Okay, I agree it should an improvement by at least handling the "_rpc_applicationUpdated" messages. Can you update the README over here to point to the repo and commit hash you used? I guess it's google/ios-webkit-debug-proxy@20679aa?

@jimblandy
Copy link
Contributor

I'll take care of updating the README.

@jimblandy jimblandy closed this Jul 25, 2016
@jimblandy jimblandy reopened this Jul 25, 2016
@jimblandy jimblandy merged commit 86ec52d into mozilla:master Jul 25, 2016
@artygus
Copy link
Contributor Author

artygus commented Jul 25, 2016

@jryans oops, sorry I think I missed the comment @jimblandy thanks!

@jimblandy
Copy link
Contributor

@artygus No problem!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants