web-ext lint --warnings-as-errors has no effect

[kumar303]

Is this a bug or feature request?

It's a bug with #613

What is the current behavior?

Run web-ext lint --warnings-as-errors on some extension source that produces warnings.

What is the expected or desired behavior?

It should report the warnings as errors not as warnings. I only see them reported as warnings.

Version information

(Please fill this in for bug reports.)

• Output of web-ext --version: ec7a1ee
• Output of node --version: v6.3.0
• Output of npm --version: 3.10.8
• Firefox version:
• Your OS and version: Mac OS X

[kumar303]

@josteink is this also happening for you on master? Could you take a look?

[josteink]

I'll be honest and admit I only tested with the shorthand alias -w. I can take a closer look later this evening.

[kumar303]

I see the same problem with -w. Maybe something didn't get merged in on the web-ext or linter side?

[josteink]

I've just tested and as far as I can tell, it all works as it should.

This is what I did and this is the output:

$ git pull upstream master
$ npm install
$ npm run build
$ ls ./tests/fixtures/warning
index.js  __MACOSX  manifest.json
$ cat ./tests/fixtures/warning/manifest.json 
{
  "description": "just a test addon with the manifest.json format, but bad",
  "manifest_version": 2,
  "name": "My Bad Addon",
  "version": "0.0.1",
  "applications": {
      "gecko": {
          "id": "@webextension-guid"
      }
  },
  "permissions": [
    "tbas"
  ]
}
$ ./node_modules/addons-linter/bin/addons-linter --warnings-as-errors ./tests/fixtures/warning || echo YES FAILED
Validation Summary:

errors          0              
notices         0              
warnings        3              

WARNINGS:

Code                   Message                                    Description                                                                 File                       Line   Column
MANIFEST_PERMISSIONS   /permissions: Unknown permissions "tbas"   See https://mzl.la/1R1n1t0 (MDN Docs) for more information.                 manifest.json                           
                       at 0.                                                                                                                                                          
HIDDEN_FILE            Hidden file flagged                        Hidden files complicate the review process and can contain sensitive        __MACOSX/._index.js                     
                                                                  information about the system that generated the add-on. Please modify the                                           
                                                                  packaging process so that these files aren't included.                                                              
HIDDEN_FILE            Hidden file flagged                        Hidden files complicate the review process and can contain sensitive        __MACOSX/._manifest.json                
                                                                  information about the system that generated the add-on. Please modify the                                           
                                                                  packaging process so that these files aren't included.                                                              
YES FAILED
$ ./bin/web-ext lint --warnings-as-errors -s ./tests/fixtures/warning || echo YES FAILED
Validation Summary:

errors          0              
notices         0              
warnings        1              

WARNINGS:

Code                   Message                                    Description                                                   File            Line   Column
MANIFEST_PERMISSIONS   /permissions: Unknown permissions "tbas"   See https://mzl.la/1R1n1t0 (MDN Docs) for more information.   manifest.json                
                       at 0.                                                                                                                                 
YES FAILED
$ ./bin/web-ext lint -w -s ./tests/fixtures/warning || echo YES FAILED       
Validation Summary:

errors          0              
notices         0              
warnings        1              

WARNINGS:

Code                   Message                                    Description                                                   File            Line   Column
MANIFEST_PERMISSIONS   /permissions: Unknown permissions "tbas"   See https://mzl.la/1R1n1t0 (MDN Docs) for more information.   manifest.json                
                       at 0.                                                                                                                                 
YES FAILED

And to be clear: The key point of this feature is having warnings cause a non-zero return-code which can be picked up in subsequent scripts. Having the warnings listed as errors was not something I had in mind.

Edit: Note the test-case I'm using here is not checking in the the web-ext repo. You'll have to create it yourself based on the output here.

[kumar303]

And to be clear: The key point of this feature is having warnings cause a non-zero return-code which can be picked up in subsequent scripts. Having the warnings listed as errors was not something I had in mind.

ah ok! That's where I was confused. I didn't check the exit code. Thanks for the clarification. This bug is invalid.