chore: extend eslint recommendations #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpl
approved these changes
Nov 7, 2016
pdehaan
reviewed
Nov 7, 2016
| @@ -13,6 +13,7 @@ | |||
| "node": true, | |||
| "es6": true | |||
| }, | |||
| "extends": "eslint:recommended", | |||
There was a problem hiding this comment.
FWIW, there is also a "plugin:flowtype/recommended" config which you can extend.
"extends": [
"eslint:recommended",
"plugin:flowtype/recommended"
],Extending that flowtype recommended config now returns 15 errors:
npm run lint
> [email protected] lint /Users/pdehaan/dev/github/mozilla/web-ext
> grunt lint
Running "lint" task
Running "eslint:js" (eslint) task
Done.
➜ web-ext git:(master) subl .
➜ web-ext git:(master) npm run lint
> [email protected] lint /Users/pdehaan/dev/github/mozilla/web-ext
> grunt lint
Running "lint" task
Running "eslint:js" (eslint) task
/Users/pdehaan/dev/github/mozilla/web-ext/src/cmd/build.js
52:20 error There must be a space before union type annotation separator flowtype/union-intersection-spacing
52:20 error There must be a space after union type annotation separator flowtype/union-intersection-spacing
/Users/pdehaan/dev/github/mozilla/web-ext/src/cmd/run.js
309:52 error There must be a space before union type annotation separator flowtype/union-intersection-spacing
309:52 error There must be a space after union type annotation separator flowtype/union-intersection-spacing
/Users/pdehaan/dev/github/mozilla/web-ext/src/cmd/sign.js
136:12 error There must be a space before union type annotation separator flowtype/union-intersection-spacing
136:12 error There must be a space after union type annotation separator flowtype/union-intersection-spacing
170:8 error There must be no space before return type colon flowtype/space-before-type-colon
/Users/pdehaan/dev/github/mozilla/web-ext/src/errors.js
92:16 error There must be a space before union type annotation separator flowtype/union-intersection-spacing
92:16 error There must be a space after union type annotation separator flowtype/union-intersection-spacing
92:39 error There must be a space before union type annotation separator flowtype/union-intersection-spacing
92:39 error There must be a space after union type annotation separator flowtype/union-intersection-spacing
/Users/pdehaan/dev/github/mozilla/web-ext/src/firefox/preferences.js
8:18 error Use "boolean", not "bool" flowtype/boolean-style
/Users/pdehaan/dev/github/mozilla/web-ext/src/util/is-directory.js
17:60 error Use "boolean", not "bool" flowtype/boolean-style
/Users/pdehaan/dev/github/mozilla/web-ext/src/util/manifest.js
71:65 error There must be a space before union type annotation separator flowtype/union-intersection-spacing
71:65 error There must be a space after union type annotation separator flowtype/union-intersection-spacing
✖ 15 problems (15 errors, 0 warnings)
Warning: Task "eslint:js" failed. Use --force to continue.
Aborted due to warnings.Good news is that all the issues can be auto-fixed using:
$ ./node_modules/.bin/eslint tasks tests src Gruntfile.js webpack.config.js --fixAlthough it does give me one error (which seems to be a max-len violation due to auto-formatted code):
$ npm run lint
> [email protected] lint /Users/pdehaan/dev/github/mozilla/web-ext
> grunt lint
Running "lint" task
Running "eslint:js" (eslint) task
/Users/pdehaan/dev/github/mozilla/web-ext/src/cmd/sign.js
170:1 error Line 170 exceeds the maximum line length of 80 max-len
✖ 1 problem (1 error, 0 warnings)There was a problem hiding this comment.
Thanks! I didn't know about that. I added it in #631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.