Friday fixes #44
Merged
Friday fixes #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix snippets configuration option not working
These need to be passed to haskell-lsp in order to declare it in the server capabilities.
…tion Register rename and implementation provider
This is necessary, because when we upgrade cabal-helper, and transivitely cabal-plan to version 0.5.0.0 in haskell#1126, the minimum cabal-version is 2.2. However, each stack snapshot ships with its own version of cabal-install that can not be changed. The latest lts for ghc-8.2.2 is 11.18, which ships with a cabal-install version of 2.0.0.1, which is too old for cabal-plan 0.5.0.0. However, in general, there is nothing that forces us to drop support for GHC 8.2.2. Overriding the compiler version should be possible, e.g. taking the snapshort 14.8 and overriding the GHC version, but this requires us to do manual constraint solving. Could be done if needed.
We must run the liquid exe to generate results to be parsed.
Before it would make vscode freeze trying to output 100s of messages.
Make sure the liquid haskell test files are generated for unit-test
Ignore the stack PATH fix if the env var is not set
This reverts commit b0a01e7.
This needs alanz/haskell-dockerfiles#2 for CI, to update the base image GHC and liquid haskell version.
This reverts commit 9fc2dcc.
Bump haskell-lsp et al to 0.18.0.0
I had to look up an additional website where specifically to find this policy. I clarified this in the readme.
…into new-haskell-lsp-options
Some JSON parsing tools won't accept the last comma in an object.
README.md > vim/coc setup > last comma in the json object doesn't parse.
Update LSP options for new haskell-lsp-0.18
lukel97
approved these changes
Nov 19, 2019
Various improvements and fixes over shake install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
mapFileFromVFSghc-events-analyse.The patch can't be merged yet as it requires a new haskell-lsp and lsp-test version.