Skip to content

fix: fix regression from #1401 and allow CI test failures to break gitthub workflow #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2022
Merged

fix: fix regression from #1401 and allow CI test failures to break gitthub workflow #1443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e83d3e
fix: fix regression from #1401 and allow CI test failures to break gi…
BertKleewein Mar 10, 2022
ce343b4
temporary rollback to verify break works
BertKleewein Mar 10, 2022
13866be
put change back in
BertKleewein Mar 10, 2022
47ee1eb
add comment to fix
BertKleewein Mar 14, 2022
fb3b78e
fix misspelling
BertKleewein Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/mqttjs-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
- run: npm ci
- name: Node Tests
run: npm run test:node
continue-on-error: true
env:
CI: true
DEBUG: "mqttjs"
Expand Down
13 changes: 12 additions & 1 deletion lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,7 +1583,18 @@ MqttClient.prototype._handleAck = function (packet) {
const that = this
let err

if (!cb || cb === nop) {
// Checking `!cb` happens to work, but it's not technically "correct".
//
// Why? This code assumes that "no callback" is the same as that "we're not
// waiting for responses" (puback, pubrec, pubcomp, suback, or unsuback).
//
// It would be better to check `if (!this.outgoing[messageId])` here, but
// there's no reason to change it and risk (another) regression.
//
// The only reason this code works is becaues code in MqttClient.publish,
// MqttClinet.subscribe, and MqttClient.unsubscribe ensures that we will
// have a callback even if the user doesn't pass one in.)
if (!cb) {
debug('_handleAck :: Server sent an ack in error. Ignoring.')
// Server sent an ack in error, ignore it.
return
Expand Down