Skip to content

WebGLTextures: Increase default precision for depth buffers with WebGL 2. #26764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2023
Merged

WebGLTextures: Increase default precision for depth buffers with WebGL 2. #26764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44d80ee
WebGLTextures: Increase default precision for depth buffers with WebG…
Mugen87 Sep 15, 2023
80aae3c
Examples: Update screenshots.
Mugen87 Sep 15, 2023
e8a0afd
Examples: Update screenshots.
Mugen87 Sep 15, 2023
7d602ac
Add webgl2_multisampled_renderbuffers to exception list.
Mugen87 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified examples/screenshots/webgl2_multisampled_renderbuffers.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/renderers/webgl/WebGLTextures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,7 @@ function WebGLTextures( _gl, extensions, state, properties, capabilities, utils,

if ( renderTarget.depthBuffer && ! renderTarget.stencilBuffer ) {

let glInternalFormat = _gl.DEPTH_COMPONENT16;
let glInternalFormat = ( isWebGL2 === true ) ? _gl.DEPTH_COMPONENT24 : _gl.DEPTH_COMPONENT16;

if ( isMultisample || useMultisampledRTT( renderTarget ) ) {

Expand Down
1 change: 1 addition & 0 deletions test/e2e/puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ const exceptionList = [
'webgl_test_memory2',
'webgl_tiled_forward',
'webgl2_volume_instancing',
'webgl2_multisampled_renderbuffers',
'webgl_points_dynamic',

// TODO: implement determinism for setTimeout and setInterval
Expand Down