Skip to content

Handle nested EOL delimiter inside wrap delimiter properly #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Conversation

mrodrig
Copy link
Owner

@mrodrig mrodrig commented Jan 9, 2022

Background Information

I have...

  • added at least one test to verify the failure condition is fixed.
  • verified the tests are passing.

As reported in #214, there was a bug with how the CSV parser was handling quoted fields which had newlines (or EOL delimiters) embedded in them. Since the value is wrapped in quotes, the EOL delimiter should not be interpreted as though it's a new line or the start of another field as it previously was. This commit introduces a fix to ensure that quoted fields are parsed properly regardless of whether there is a nested EOL delimiter inside.

Fixes #214
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 5bbd611 on fix-214 into e65ebb0 on stable.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 5bbd611 on fix-214 into e65ebb0 on stable.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.039% when pulling 5bbd611 on fix-214 into e65ebb0 on stable.

@mrodrig mrodrig merged commit a608a38 into stable Jan 9, 2022
@mrodrig mrodrig deleted the fix-214 branch January 9, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants