fix(ios): prevent crash when capturePhoto has no active video connection #3637
+132
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure AVCaptureSession is running and video connection is both enabled + active - Add auto-repair: re-add AVCapturePhotoOutput inside begin/commitConfiguration - Reset session preset to .photo if available, restart session if necessary - Add short polling window (0.5s, 50ms interval) to handle timing races - Preserve existing logging and behavior for resolution, flash, depth, portrait effects, and distortion correction
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Could you please approve this update? i cannot take photo on iphone17 pro |
|
Hello There, Same here...we are getting reports about this... thanks in advance |
|
+1 When can we expect it to be merged and released? We need to know whether to patch it or wait for the official fix |
|
Running into multiple instances of this as well. Do we have an ETA or is it worth patching ourselves? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a crash on iOS devices where calling
AVCapturePhotoOutput.capturePhoto(with:delegate:) could throw:
The crash was caused by attempting to capture a photo when the AVCaptureSession was running but the video connection was not yet active (e.g., right after camera switch, format change, or session interruption).
Changes
Tested on
Related issues