Fix py26 compatibility issue, add mock to tox #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtheb
added a commit
that referenced
this pull request
Mar 20, 2014
Fix py26 compatibility issue, add mock to tox
|
Thanks, I had done the same to add changes to add mock to tox but didn't push it yet. I never really understood how Travis could build & test correctly without this, do you have any idea why? It wa |
|
I dunno. I guess it's just installed by default? At any rate: thanks for the merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite is still broken for py26 because of unittest.skipUnless, but I don't think that's related to your branch. Otherwise, this looks fine to me. I'd rather see a controlled exception than a KeyError.