-
Notifications
You must be signed in to change notification settings - Fork 683
Add support for env variables with SFTP client. #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@mscdex we also would like to have such a solution. |
That would be the preferred approach. |
@mscdex thanks for the help, I did the changes. If it looks okay, I'll have a look at updating the docs. |
Co-authored-by: mscdex <[email protected]>
Co-authored-by: mscdex <[email protected]>
All that's needed now is a unit test. You'll probably have to use one similar to the last one in the SFTP test script to verify the environment is being sent properly before starting the subsystem. |
9db57fe
to
3659269
Compare
Co-authored-by: mscdex <[email protected]>
@mscdex so this look okay right? Would you be able to include it in the next release? |
@mscdex I'd also be interested in this solution. Anything that can be done to support this / move this forward? |
Is there anything we could do, to speed this up? |
Yea, I really need this ASAP , so if we can help you somehow to speed the process let us know |
@mscdex it's been quite a while since this is open, would you able to at least give some pointers on when you plan to work this project? thanks! |
This relates to and closes this issue: #1433
I basically saw how this was implemented in the exec() method in
client.js
and did a similar implementation.I seems that it might be better to add an additional parameter to the sftp() method, i.e. in
client.js
it would appear assftp(env, cb)
, I wasn't entirely sure, what do you think? Thanks!