V07 value impl revision 2 #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f integer overflow
|
@komamitsu |
| } | ||
|
|
||
|
|
||
| public static class MapEntry { |
There was a problem hiding this comment.
We don't need MapEntry class because we can use Map.Entry<Value, Value>.
There was a problem hiding this comment.
Right. Fixed to use Map.Entry
…test Fix unit test errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several API changes:
unpackValue(var); var.asIntegerValue().integerValue)publicfrom interface definitions, sincepublicis the default scopeI'll work on adding test cases,
proper treatment of float/double values, etc. in the next pull request.