lint errors on npm run build

[bdefore]

I can't run npm build due to linting errors:

> material-ui@0.12.3 build /[REDACTED]/node_modules/material-ui
> npm run eslint && babel --stage 1 ./src --out-dir ./lib


> material-ui@0.12.3 eslint /[REDACTED]/node_modules/material-ui
> gulp eslint

[14:25:12] Using gulpfile /[REDACTED]/node_modules/material-ui/gulpfile.js
[14:25:12] Starting 'eslint'...
[14:25:13] 'eslint' errored after 1.08 s
[14:25:13] ESLintError in plugin 'gulp-eslint'
Message:
    mixins must be placed after childContextTypes
Details:
    fileName: /[REDACTED]/node_modules/material-ui/src/app-bar.jsx
    lineNumber: 13

There's a lot more than just that one.

[bdefore]

in case anyone else wants to work around this #1862

[louy]

It's not failing for me. Do you have an .eslintrc file in a parent directory?
The rule that's enforced here doesn't exist in the project's config file.

[bdefore]

@louy i'm building material-ui manually from a fork, so it lives in project-root/node-modules/material-ui i do have project-root/.eslintrc ... perhaps it would be easier on contributors to manually specific the .eslintrc path via https://github.com/adametry/gulp-eslint#eslintconfigfilepath ?

[bdefore]

I see, the problem is that for my npm postinstall step i have cd node_modules/material-ui && npm i && npm run build and that's not applying the current working directory of node-modules/material-ui. What's the conventional way to handle this in gulp?

[bdefore]

(cd node_modules/material-ui && gulp eslint) still has the same error. but if i remove my .eslintrc file it works.

[louy]

By default, ESLint will look for configuration files in all parent folders up to the root directory. This can be useful if you want all of your projects to follow a certain convention, but can sometimes lead to unexpected results. To limit ESLint to a specific project, place "root": true inside the eslintConfig field of the package.json file or in the .eslintrc file at your project's root level. ESLint will stop looking in parent folders once it finds a configuration with "root": true.
— ESLint User Guide

I think adding "root": true to .eslintrc is not a bad idea.

@shaurya947 what do you think?

[louy]

@bdefore in the meaning time you can create a .eslintrc file in node_modules/ with the following contents:

{
  "root": true
}

[oliviertassinari]

@louy Sounds like a good idea.

[bdefore]

@louy I can verify that setting root: true in my local fork fixes my use case. Thanks!