[core] Add React.createRef support #11757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
feat/allow-createRef-input
branch
3 times, most recently
from
758ca0f to
f3a3f6a
Compare
oliviertassinari
force-pushed
the
feat/allow-createRef-input
branch
from
f3a3f6a to
f9bb9ec
Compare
|
@t49tran Thank you! |
| @@ -11,7 +11,7 @@ export interface TextareaProps | |||
| disabled?: boolean; | |||
| rows?: string | number; | |||
| rowsMax?: string | number; | |||
| textareaRef?: React.Ref<any>; | |||
| textareaRef?: React.Ref<any> | React.RefObject<any>; | |||
There was a problem hiding this comment.
This is not needed. React.Ref<> includes React.RefObject<>
type Ref<T> = string | { bivarianceHack(instance: T | null): any }["bivarianceHack"] | RefObject<T>;There was a problem hiding this comment.
You are right, feel free to make another PR to remove it.
There was a problem hiding this comment.
There was a problem hiding this comment.
React.Ref<any> | React.RefObject<any> can also be found in couple of other places, do you want to work on it @franklixuefei ? Otherwise I can make a PR to replace them.
There was a problem hiding this comment.
@t49tran Sorry I was busy working on something else lately. Please go ahead! Thanks! 😄
acroyear
pushed a commit
to acroyear/material-ui
that referenced
this pull request
Jul 14, 2018
* feat: make input accept both ref callback and ref from React.createRef * feat: update [TextArea] to accept React.createRef object as inputRef * feat: update typescript and proptypes declaration for inputRef * test: add inputRef test for input * simpler logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve the issue with
<Input>,<TextField>and<TextArea>components don't acceptReact.createRefasinputRefortextareaRef.Issues raised in #11709 #11486.
The idea for the solution is partly from #11293 and #11486.
Closes #11709