Skip to content

[bugfix] moves key prop to TableHeaderColumn #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[bugfix] moves key prop to TableHeaderColumn #1625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/table/table-header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,19 +127,19 @@ let TableHeader = React.createClass({
},

_getSelectAllCheckboxColumn(props) {
if (!this.props.displaySelectAll) return this._getCheckboxPlaceholder(props);
if (!this.props.displaySelectAll) return this._getCheckboxPlaceholder(props);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the trailling space?


const checkbox =
<Checkbox
key="selectallcb"
name="selectallcb"
value="selected"
disabled={!this.props.enableSelectAll}
checked={this.props.selectAllSelected}
onCheck={this._onSelectAll} />;

return (
<TableHeaderColumn style={{width: 24}}>
<TableHeaderColumn style={{width: 24}}
key="selectallcb">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a different key for each element?

{checkbox}
</TableHeaderColumn>
);
Expand Down