dialog render-to-layer version

[chrismcv]

This PR created a wrapped dialog component that uses the render to layer component to put the dialog in a separate dom tree.

The reason for the wrapping is so that refs can continue to be used as normal within the dialog component for animation.

(This doesn't depend on the #2043 branch)

[oliviertassinari]

Why did you remove this property?

[chrismcv]

carelessness - merging from #1845 by hand... apologies

[chrismcv]

@oliviertassinari - rebasing this wasn't as the warning have moved completely, so git merge had a bad day at the office. I've manually rolled in your changes. Can I suggest no further changes to dialog.jsx get added to master until this is merged (assuming that is planned for soon.)

[oliviertassinari]

@chrismcv Sorry about this. I had to merge the fix #2142. Otherwise, I agree, let's freeze dialog.jsx.

[oliviertassinari]

Shouldn't the show property be required instead of adding a default value?

[oliviertassinari]

There is two setState call. Do you if this will have an impact on perf?
Actually, it looks like we don't need to have show in the state.
Can't we just use the show property?

[chrismcv]

@oliviertassinari - your'e right, state not required, have removed :)

[oliviertassinari]

You removed the function call to this method.
So I think that we can remove preventScrolling and allowScrolling method.

This component is also used by LeftNav, I have just checked, it should be fine.
I think that it will also be good to move _allowScrollingand _preventScrolling inside _applyAutoLockScrolling since their are only called by this method.

[chrismcv]

componentWillUnmount calls _allowScrolling, had a think about combining, but think its best to keep this separate. Does that sound ok?

[oliviertassinari]

@chrismcv I think that I'm done with my comments and that we can soon merge 😄.

[chrismcv]

@oliviertassinari - defaultOpen added back in, and squashed.

[oliviertassinari]

I have noticed one issue. When we open the dialog for a second time, the height is not correct.
I think that it's linked to the render-to-layout component since this bug only happen if you reopen the dialog at max one second after.

[chrismcv]

@oliviertassinari apologies - rebase caused some confusion there, hence open and close. I had another rebase issue so manually merged it (see b4b7bb9).

Does this fix your height issue?

[oliviertassinari]

@chrismcv The height issue is gone, great work 👍!