-
Notifications
You must be signed in to change notification settings - Fork 67
Awesome API Documentation #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1781cc1
to
fe620e4
Compare
@dignifiedquire should be ok now, please leave feedback :) |
Cool stuff @victorbjelkholm, not super happy about this though: which is not your fault, but this needs some work in the theme/parsing |
So it turns out the general notion of how to document this in jsdoc are one of the two following ComplexAllows for individual property descriptions, but adds another section /**
* @typedef {Object} Protocols
* @param {Array} table
* @param {Object} names
* @param {Object} codes - protocols
*/
/**
* @returns {Protocols}
*/ SimpleDoes not allow for description of individual properties /**
* @returns {{table: Array, names: Object, codes: Object}}
*/ |
PR is from me, might be better for @dignifiedquire or you to review it :) |
@victorbjelkholm could you update the return values to use one of the two variants I listed above please? |
@dignifiedquire thanks, applied where applicable |
1 similar comment
* @returns {Array.<Object>} protocols - All the protocols the address is composed of | ||
* @returns {Number} protocols[].code | ||
* @returns {Number} protocols[].size | ||
* @returns {String} protocols[].name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victorbjelkholm you missed this one :)
LGTM |
Ref ipfs/js-ipfs#615