Skip to content

feat: BlockEncoder#encode and BlockDecoder#decode can be async #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: BlockEncoder#encode and BlockDecoder#decode can be async #282

wants to merge 3 commits into from

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Dec 11, 2023

I want to be able to use async functions in my Block encode/decode.

@gobengo
Copy link
Contributor Author

gobengo commented Dec 11, 2023

wdyt @Gozala @rvagg ?

@rvagg
Copy link
Member

rvagg commented Dec 13, 2023

What async codecs do you need this for? is it for codecs involving encryption, or something else? It's just unfortunate to introduce an async in createUnsafe which is supposed to be the fast one. I think it'd be mostly optimised away in the common case of codecs that are sync, but it is a slightly annoying UX hurdle when we've been exporting this as sync the whole time.

@rvagg rvagg mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gobengo @rvagg