Skip to content

Please ignore: Improvig typechecknig experience #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Please ignore: Improvig typechecknig experience #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbad7bb
chore: test typechecking behavior
Gozala Oct 9, 2020
6eccef7
retrigger CI
Gozala Oct 9, 2020
576afe0
chore: run only pull or push
Gozala Oct 9, 2020
57c44ca
chore: disable build of typedefs for tests
Gozala Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
on: [push, pull_request]
on:
push:
branches:
- master
- main
- default
pull_request:
branches:
- '**'

name: Typecheck
jobs:
test:
check:
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"publish": "npm_config_yes=true npx ipjs@latest publish",
"lint": "standard",
"check": "tsc --noEmit --noErrorTruncation",
"test:cjs": "npm run build && mocha dist/cjs/node-test/test-*.js && npm run test:cjs:browser",
"test:cjs": "npm run build:js && mocha dist/cjs/node-test/test-*.js && npm run test:cjs:browser",
"test:node": "hundreds mocha test/test-*.js",
"test:cjs:browser": "polendina --cleanup dist/cjs/browser-test/test-*.js",
"test": "npm run lint && npm run test:node && npm run test:cjs",
Expand Down
2 changes: 1 addition & 1 deletion src/cid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ const parseCIDtoBytes = (source, base) => {
// CIDv0 is parsed differently
case 'Q': {
const decoder = base || base58btc
return [base58btc.prefix, decoder.decode(`${base58btc.prefix}${source}`)]
return [base58btc.preflx, decoder.decode(`${base58btc.prefix}${source}`)]
}
case base58btc.prefix: {
const decoder = base || base58btc
Expand Down