🐛 cpp-linter silently broke
#129
Assignees
Labels
Comments
burgholzer
added
bug
burgholzer
added a commit
that referenced
this issue
Aug 31, 2022
## Description Fixes #129. Signed-off-by: burgholzer <[email protected]>
MarlQ
pushed a commit
to MarlQ/qcec
that referenced
this issue
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mqt.qcec version
latest
OS
any
Python version
No response
C++ compiler
No response
Additional environment information
No response
Description
The tool that is being used for linting the C++ part of our codebase (cpp-linter) recently got a major update (https://github.com/cpp-linter/cpp-linter-action/releases/tag/v1.5.0) a couple of days ago. That release partially fixed cpp-linter/cpp-linter-action#73, which QCEC was working around in https://github.com/cda-tum/qcec/blob/2d2ea8253074397cc3afdddfb93d6d4de0fb6042/.github/workflows/cpp-linter.yml#L41.
This workaround now silently broke with the most recent update.
This hasn't been caught by the latest PRs since they did not contain C++ related changes, but popped up when we tried to introduce the action for the MQT DD Package in cda-tum/dd_package#103.
Expected behavior
The linter should work as expected.
How to Reproduce
Run the cpp-linter action or Python package with these two lines
https://github.com/cda-tum/qcec/blob/2d2ea8253074397cc3afdddfb93d6d4de0fb6042/.github/workflows/cpp-linter.yml#L37-L38
set to false.
The text was updated successfully, but these errors were encountered: