fix(inspector): terminate stdio server on disconnect #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSEHonoTransport that was used for the stdio proxy does not relay the underlying stream's close event so its own `onclose` handler never gets called. This then causes the underlying stdio process to be left running even when it was actually disconnected on the other end. This PR fixes the issue by manually triggering the `onclose` handler when the stream closes. This is a workaround and should be removed when the upstream code referenced in the comment is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSEHonoTransportthat was used for the stdio proxy does not relay the underlying stream's close event so its ownonclosehandler never gets called. This then causes the underlying stdio process to be left running even when it was actually disconnected on the other end.This PR fixes the issue by manually triggering the
onclosehandler when the stream closes. This is a workaround and should be removed when the upstream code referenced in the comment is fixed.