-
Notifications
You must be signed in to change notification settings - Fork 12.9k
fix: fix the problem that nested list cannot be parsed correctly #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
eeffd67
to
fc2d057
Compare
@harawata Is it possible to merge this pr |
@harawata TBR. Thanks! |
@juzi214032 calm down. We are all volunteers here and doing this work on our own time. Yes, we accept PRs, but they need to be carefully reviewed before being merged. Someone will take a look at this PR eventually. |
@jeffgbutler ok, sorry. I just want to make sure this project is still in development |
Hello @juzi214032 , This change breaks the contract of @Test
void testIndexedName() {
PropertyTokenizer tokenizer = new PropertyTokenizer("simpleName[2]");
assertEquals("simpleName", tokenizer.getName());
assertEquals("simpleName[2]", tokenizer.getIndexedName()); // actual = "simpleName"
assertNull(tokenizer.getChildren());
assertEquals("2", tokenizer.getIndex());
assertFalse(tokenizer.hasNext());
} However, it does not break any existing tests which means either 1) |
@harawata thanks review, i will try to fix it |
close #2103