SpringManagedTransaction#close broken backward-compatibility between 1.3.x and 2.0.x

[SElab2019]

When I try to upgrade mybatis-spring from 1.3.2 to the version after 2.0.0. The upgrade breaks my existing code when I extend SpringManagedTransaction and override method Close with SQLException. e.g.

public class Demo extends SpringManagedTransaction{
	private Connection connection;

	public Demo(DataSource dataSource) {
		super(dataSource);
	}

	@Override
	public void close() throws SQLException {
		try {
			if(connection != null){
				if(!TransactionSynchronizationManager.isSynchronizationActive()){
					if(connection.isReadOnly()){
						connection.setReadOnly(false);
					}
				}else if(!TransactionSynchronizationManager.isActualTransactionActive()){
					if(connection.isReadOnly()){
						connection.setReadOnly(false);
					}
				}
			}
		} catch (Exception e) {
			LOGGER.error("ha reset read only error:" + e.getMessage(), e);
		}
			
		super.close();
	}
}

The code should pass. However, it throws an error:

close() in Demo cannot override close() in org.mybatis.spring.transaction.SpringManagedTransaction
 overridden method does not throw java.sql.SQLException

[kazuki43zoo]

@SElab2019 Thanks for your report!

This issue is bug(This issue was included by 5ca5f2d). We will revert it at 2.0.4.

[kazuki43zoo]

@SElab2019

I've fixed and deployed the 2.0.4-SNAPSHOT version on OSS sonatype repository. Please try it if you have a time. Thanks.

[SElab2019]

@kazuki43zoo

I've fixed and deployed the 2.0.4-SNAPSHOT version on OSS sonatype repository. Please try it if you have a time. Thanks.

You are welcome. Thanks for confirming and quick fixing. It could solve the issue.