-
Notifications
You must be signed in to change notification settings - Fork 2.6k
mybatis-spring-2.0.x (Java 8, Spring 5.x and Spring Batch 4.x) #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @emacarron, It's been a long time. I'm working on next release of MyBatis-Spring based on Spring 5.x. New version of HibernateDaoSupport required access to SessionFactory, while MyBatis SqlSession do not supported. In addition, direct use of getSqlSession() make me wonder whether it's MyBatis SqlSession or Spring's managed SqlSessionTemplate. Would you recall why we changing SqlSessionTemplate to SqlSession in following urls? There is no track on code.google.com. I afraid it might be important changes. pboonphong@2a0ab16 -- |
# Conflicts: # pom.xml
src/site/ko/xdoc/factorybean.xml
Outdated
@@ -1,7 +1,7 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<!-- | |||
|
|||
Copyright 2010-2016 the original author or authors. | |||
Copyright 2010-2017 the original author or authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some files have not changed so the year should keep in 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. 530e0bf was reverted.
# Conflicts: # pom.xml
Sorry for the late reply!! Opposite to JdbcTemplate or HIbernateTemplate, SqlSessionTemplate is an SqlSession so there is no need to return the implementation (the template). The idea behind that is to make code as generic and simple as possible: no need to do specific code for mybatis-spring or to know the specific class that it uses. I have seen you added a new method getSqlSessionTemplate() that returns de same instace that the existing getSqlSession method. I would not change that. Looks quite confusing having two methods for the same thing. |
TODO:
Replace Mockrunner with Mockito 2.x or H2/HSQLDB (TBD)Keep Mockrunner -> see Consider to use Mockito instead of Mockrunner #167Release Date: After Spring 5.x and Spring Batch 4.x released
FIXME: Enable SqlSessionTemplateAsyncAfterCompletionTest after migrate BMUnitRunner to BMUnitExtenson