Skip to content

Add a cluster editor #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 4, 2021
Merged

Add a cluster editor #230

merged 21 commits into from
Oct 4, 2021

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented Sep 27, 2021

Currently it's possible to generate random clusters (formerly known as creatures), but unlike mandalas, there's no way to edit one if you decide that there's something about it that you'd like to change. This means, for instance, that if a randomly-generated cluster looks nice but needs a hat, or if it has arms you don't like, or if you find something cool in the gallery but want to remix it a bit, you will be able to make those changes.

It also isn't currently possible to randomly generate a cluster with lots of complexity; the data structure to represent a cluster is defined recursively, however, so this editing UI--however horrible this initial version is--allows for the construction of clusters of arbitrary complexity.

Note that the UX for this is currently terrible, but we can improve on it in future PRs.

To do

  • It should be possible to change existing attachments.
  • It should be possible to delete attachments.
  • It should be possible to add new attachments.
  • It should be possible to add/delete/change nested symbols.
  • Navigating back in browser history (undo) collapses the "Edit cluster" expandable, fix this or file a bug for it.
  • Some of the code uses type constraints but the constraints aren't being properly type-checked; I filed Spread syntax ignores generic type constraints microsoft/TypeScript#46146. It would be nice to properly type check them, though.
  • Oh my god this UX is terrible, fix it or file a bug to do it later.

@toolness toolness marked this pull request as ready for review October 4, 2021 19:08
@toolness toolness merged commit 849afc2 into main Oct 4, 2021
@toolness toolness deleted the creature-editor branch October 4, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant